Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non-ASCII names previously retained Unicode, while the proposed
IRI_UTF_fixstripped unsupported letters and could merge unrelated entities into/web-pages/thing. this change generates ASCII IDs usingaccount.language, with German umlaut rules and explicit ICU routes for supported scriptsCompatibility and setup
kg-buildandallnow require PyICU 2.16.2 and native ICU 74.2. non-ASCII generation rejects another linked ICU version to keep identifiers reproducible. unsupported readings, including Japanese kanji, use deterministic fallback IDs. regenerated IDs may change; this PR does not migrate or delete stored entitiesValidation
tests/kg_buildtests passed on Python 3.14kg-buildandallsmoke checks passedSpecialist review
independent identity and Unicode/packaging reviews found 2 issues, both fixed in follow-up commit
169d361: repeated duplicate allocation could advance its suffix, and Mandarin private-use subtags could disable transliteration. regression tests cover bothCloses #34