Repository navigation
Check the SCR peer certificate after a resumed handshake - #11939
Open
holtrop-wolfssl wants to merge 1 commit into
Open
holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
A resumed handshake has no Certificate message, so no peer certificate hash was cached and the first renegotiation of a resumed connection accepted any certificate, even one for a different subject. Record in the session (and session ticket and serialized session) whether the peer sent a certificate and its hash, and restore it into the secure renegotiation state when a resumption is confirmed. A renegotiation of a resumed session that does not record this refuses any peer certificate with SCR_DIFFERENT_CERT_E. The peer certificate is now hashed whether or not renegotiation_info was negotiated, as a later resumption may negotiate it.
|
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A resumed handshake has no Certificate message, so no peer certificate hash was cached and the first renegotiation of a resumed connection accepted any certificate, even one for a different subject.
Record in the session (and session ticket and serialized session) whether the peer sent a certificate and its hash, and restore it into the secure renegotiation state when a resumption is confirmed. A renegotiation of a resumed session that does not record this refuses any peer certificate with SCR_DIFFERENT_CERT_E. The peer certificate is now hashed whether or not renegotiation_info was negotiated, as a later resumption may negotiate it.
Fixes ZD#22694 issue C.
Testing
How did you test?
Checklist