[julek-wolfssl]

wolfSSL_BIO_read_filename() closed the BIO's existing file even when the BIO did not own it. It also kept the closed FILE* in the BIO when the new file failed to open, so wolfSSL_BIO_free() closed it a second time.

• Close the old file only when the BIO has BIO_CLOSE set, and always drop it from the BIO.
• Remove the duplicate wolfSSL_BIO_read_filename() call in wolfSSL_X509_load_crl_file(), a leftover from a merge. It opened the file twice and hit the double fclose when the second open failed.

Fixes #11903

[Copilot]

🟢 Approval recommended

No active review issues block the file-ownership and cleanup fix.

No open issues 🎉

What changed in this PR

Fixes #11903 by correcting file ownership and cleanup in wolfSSL_BIO_read_filename(), preventing a double close when opening a replacement file fails.

Changes:

• Close the previous file only when the BIO owns it, and clear the stored file handle.
• Remove the duplicate file-open call during CRL loading.
• Add regression tests for failed opens, recovery, and BIO_NOCLOSE behavior.

File	Description
tests/​api/​test_ossl_bio.h	Declares and registers the new regression test.
tests/​api/​test_ossl_bio.c	Tests replacement-file failures and file ownership handling.
src/​x509.c	Removes the redundant file-open call during CRL loading.
src/​bio.c	Fixes file ownership checks, clears stale handles, and corrects the debug label.

_{Review effort: Balanced}

[github-actions]

MemBrowse Memory Report · Explore what changed →

zephyr-frdm_rw612

• FLASH: log_const_area -8 B, rodata -8 B, text +160 B (+0.1%, 282,608 B / 67,108,864 B, total: 0% used)

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• stm32-sim-stm32h753

---

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

[Marti2203]

Thanks Juliusz! I tested f2c1b8f with the reproducer from #11903 (--enable-opensslextra, ASan and release builds): the failed BIO_read_filename() followed by BIO_free() no longer reports a double free, the control (successful open) is unchanged, and in the release build an unrelated stream opened after the failed call stays open (fgetc() returns data instead of EOF). The new test_wolfSSL_BIO_read_filename and the ossl_bio group pass (19 passed, 5 skipped). The BIO_set_fp(..., BIO_CLOSE) after a successful open also covers the BIO_NOCLOSE case, and removing the duplicate call in wolfSSL_X509_load_crl_file() looks right to me.