Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
wc_NoiseSrc_*noise-source layer (WOLFSSL_NOISE_SRC) out ofrandom.c/random.hand intowolfentropy.c/wolfentropy.h, which sit outside the FIPS module boundary, and makes it share wolfEntropy's SP800-90B health tests instead of carrying a second copy.wc_EntropyHealthstruct with tunable cutoffs; the MemUse source keeps one static instance with unchanged behavior.hmin,margin, cutoff, window orstartupOctetsselects the wolfEntropy defaults; the C2000 port keeps its own cutoffs.WOLFSSL_C2000_ENTROPYnow impliesWOLFSSL_NOISE_SRCfromsettings.h.Testing
--enable-wolfEntropy=noisesrcenables the noise source on its own (without the MemUse seed source) and forces SHA-3 on;yes,noisesrcandthread,noisesrcenable both. CMake buildswolfentropy.candentropy-timers.cunconditionally, as both are self-gated.noisesrc_testgains startup-rerun, recovery, defaults and validation cases, and both KATs move to SHA3-256.noisesrc_hostCI job runsmake checkwith--enable-wolfEntropy=noisesrc --enable-all;IDE/C2000/compile.shcompileswolfentropy.cunderWOLFSSL_C2000_ENTROPY.wc_NoiseSrc_*API;IDE/C2000/README.mdupdated.