Skip to content

random: include unistd.h wherever getpid() is used #11918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stenslae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

random: include unistd.h wherever getpid() is used #11918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/configs/os-check-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,5 +573,11 @@
"run": [["./wolfcrypt/test/testwolfcrypt"]]},
{"name": "postauth-no-compat",
"comment": "Post-handshake auth without OPENSSL_EXTRA, which otherwise compiles out the handshake-end unload of SSL-owned certs and keys.",
"configure": ["--enable-postauth", "--enable-sessioncerts"]}
"configure": ["--enable-postauth", "--enable-sessioncerts"]},
{"name": "leanpsk",
"comment": "The NO_DEV_RANDOM seed path includes no system headers, so this catches an undeclared getpid() on GCC 13 too. The test-seed #warning fails -Werror and -pedantic, so extra_cflags repeats the global set minus -pedantic (and -Wno-overlength-strings, which only matters with it) and downgrades the #warning.",
"configure": ["--enable-leanpsk"],
"extra_cflags": "-Wdeclaration-after-statement -Wnull-dereference -DTEST_LIBWOLFSSL_SOURCES_INCLUSION_SEQUENCE -Werror=implicit-function-declaration -Wno-error=cpp",
"check": false,
"run": [["./wolfcrypt/test/testwolfcrypt"]]}
]
5 changes: 5 additions & 0 deletions wolfcrypt/src/random.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,11 @@ This library contains implementation for the random number generator.
#endif
#endif

#if defined(HAVE_GETPID) && !defined(WOLFSSL_NO_GETPID)
/* For getpid(): not every seed source above includes unistd.h. */
#include <unistd.h>
#endif

#if defined(WOLFSSL_TI_AM64X_R5)
#include <wolfssl/wolfcrypt/port/ti/ti-sa2ul_r5_port.h>
#endif
Expand Down
Loading