Skip to content

20261027 Coverity fixes #11908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlm2002 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

20261027 Coverity fixes #11908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85bcf97
Remove unreachable CallbackTypeEnd switch case in CRL ext-callback tests
rlm2002 Oct 27, 2026
c972c2b
Drop unreachable ret-capture around prim cleanup in rng_drbg_rbgc_test
rlm2002 Oct 27, 2026
fdd29f7
Zero-initialize Hmac before CryptoCb id test exercises it
rlm2002 Oct 27, 2026
b4adc43
Remove unreachable root_held re-check in rng_lifecycle_test
rlm2002 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/api/test_certman.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3892,7 +3892,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_rescues_critical_entry_ext(void)
crl_unk_ext_cb_accept32, &ctx), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down Expand Up @@ -3964,7 +3963,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_rescues_critical_crl_ext(void)
crl_unk_ext_cb_accept32, &ctx), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down Expand Up @@ -4006,7 +4004,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_rescues_critical_crl_ext(void)
crl_unk_ext_cb_reject32, &ctx), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down Expand Up @@ -4067,7 +4064,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_positive_return_fails_load(void)
crl_unk_ext_cb_reject_positive32, &ctx), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down Expand Up @@ -4144,7 +4140,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_noctx(void)
crl_unk_ext_cb_noctx_accept32), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down Expand Up @@ -4185,7 +4180,6 @@ int test_wolfSSL_CRL_unknown_ext_cb_noctx(void)
crl_unk_ext_cb_noctx_reject32), WOLFSSL_SUCCESS);
break;

case CallbackTypeEnd:
default:
/* Not reachable: the loop bound excludes CallbackTypeEnd. */
ExpectFail();
Expand Down
1 change: 1 addition & 0 deletions tests/api/test_hmac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,7 @@ int test_wc_HmacId_CryptoCb(void)
byte mac[WC_SHA256_DIGEST_SIZE];

XMEMSET(&seen, 0, sizeof(seen));
XMEMSET(&hmac, 0, sizeof(hmac));
ExpectIntEQ(wc_CryptoCb_RegisterDevice(TEST_HMAC_CRYPTOCB_DEVID,
test_hmac_id_cb, &seen), 0);

Expand Down
9 changes: 1 addition & 8 deletions wolfcrypt/test/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35280,9 +35280,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t rng_drbg_rbgc_test(void)
}
#ifdef WC_RNG_HAVE_LOCK
if (prim_inited) {
cleanup_ret = wc_FreeRng_PreLocked(&prim);
if ((cleanup_ret != 0) && (ret == 0))
ret = WC_TEST_RET_ENC_EC(cleanup_ret);
(void)wc_FreeRng_PreLocked(&prim);
}
#endif
if (extra_inited) {
Expand Down Expand Up @@ -37168,7 +37166,6 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t rng_lifecycle_test(void)
}
if (root_held) {
int put_ret = wc_RNG_lock_put(root, 0);
root_held = 0;
if ((api_ret == 0) && (put_ret != 0))
api_ret = put_ret;
}
Expand All @@ -37193,10 +37190,6 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t rng_lifecycle_test(void)
}
}
}
if (root_held) {
(void)wc_FreeRng_PreLocked(root);
(void)wc_RNG_lock_put(root, 0);
}
if (bank_inited) {
int fini_ret = wc_rng_bank_fini(bank);
if ((api_ret == 0) && (fini_ret != 0))
Expand Down
Loading