Skip to content

sp: do not rely on an 8-bit char when recoding the scalar #11889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philljj merged 1 commit into from
Oct 28, 2026
Merged

sp: do not rely on an 8-bit char when recoding the scalar #11889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_arm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77335,7 +77335,7 @@ static void sp_256_ecc_recode_6_8(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -96225,7 +96225,7 @@ static void sp_384_ecc_recode_6_12(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -124265,7 +124265,7 @@ static void sp_521_ecc_recode_6_17(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down
14 changes: 7 additions & 7 deletions wolfcrypt/src/sp_arm64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25891,7 +25891,7 @@ static void sp_256_ecc_recode_6_4(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -29218,7 +29218,7 @@ static void sp_256_ecc_recode_7_4(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<37; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -61623,7 +61623,7 @@ static void sp_384_ecc_recode_6_6(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -64905,7 +64905,7 @@ static void sp_384_ecc_recode_7_6(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<55; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -90286,7 +90286,7 @@ static void sp_521_ecc_recode_6_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -94267,7 +94267,7 @@ static void sp_521_ecc_recode_7_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<75; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -134315,7 +134315,7 @@ static void sp_1024_ecc_recode_7_16(const sp_digit* k, ecc_recode_1024* v)
n = k[j];
o = 0;
for (i=0; i<147; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_armthumb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102957,7 +102957,7 @@ static void sp_256_ecc_recode_6_8(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -114277,7 +114277,7 @@ static void sp_384_ecc_recode_6_12(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -128418,7 +128418,7 @@ static void sp_521_ecc_recode_6_17(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down
8 changes: 4 additions & 4 deletions wolfcrypt/src/sp_c32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26175,7 +26175,7 @@ static void sp_256_ecc_recode_6_9(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 29) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -33813,7 +33813,7 @@ static void sp_384_ecc_recode_6_15(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 26) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -41516,7 +41516,7 @@ static void sp_521_ecc_recode_6_21(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 25) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -50190,7 +50190,7 @@ static void sp_1024_ecc_recode_7_42(const sp_digit* k, ecc_recode_1024* v)
n = k[j];
o = 0;
for (i=0; i<147; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 25) {
y &= 0x7f;
n >>= 7;
Expand Down
8 changes: 4 additions & 4 deletions wolfcrypt/src/sp_c64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27487,7 +27487,7 @@ static void sp_256_ecc_recode_6_5(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 52) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -34590,7 +34590,7 @@ static void sp_384_ecc_recode_6_7(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 55) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -42171,7 +42171,7 @@ static void sp_521_ecc_recode_6_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 58) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -49895,7 +49895,7 @@ static void sp_1024_ecc_recode_7_18(const sp_digit* k, ecc_recode_1024* v)
n = k[j];
o = 0;
for (i=0; i<147; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 57) {
y &= 0x7f;
n >>= 7;
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_cortexm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42209,7 +42209,7 @@ static void sp_256_ecc_recode_6_8(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -53761,7 +53761,7 @@ static void sp_384_ecc_recode_6_12(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -67119,7 +67119,7 @@ static void sp_521_ecc_recode_6_17(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 32) {
y &= 0x3f;
n >>= 6;
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_riscv64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41317,7 +41317,7 @@ static void sp_256_ecc_recode_6_4(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -51998,7 +51998,7 @@ static void sp_384_ecc_recode_6_6(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -62661,7 +62661,7 @@ static void sp_521_ecc_recode_6_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down
14 changes: 7 additions & 7 deletions wolfcrypt/src/sp_x86_64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9334,7 +9334,7 @@ static void sp_256_ecc_recode_6_4(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<43; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -11941,7 +11941,7 @@ static void sp_256_ecc_recode_7_4(const sp_digit* k, ecc_recode_256* v)
n = k[j];
o = 0;
for (i=0; i<37; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -28427,7 +28427,7 @@ static void sp_384_ecc_recode_6_6(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<65; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -31090,7 +31090,7 @@ static void sp_384_ecc_recode_7_6(const sp_digit* k, ecc_recode_384* v)
n = k[j];
o = 0;
for (i=0; i<55; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -53327,7 +53327,7 @@ static void sp_521_ecc_recode_6_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<87; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 6 < 64) {
y &= 0x3f;
n >>= 6;
Expand Down Expand Up @@ -56091,7 +56091,7 @@ static void sp_521_ecc_recode_7_9(const sp_digit* k, ecc_recode_521* v)
n = k[j];
o = 0;
for (i=0; i<75; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down Expand Up @@ -94236,7 +94236,7 @@ static void sp_1024_ecc_recode_7_16(const sp_digit* k, ecc_recode_1024* v)
n = k[j];
o = 0;
for (i=0; i<147; i++) {
y = (word8)(int8_t)n;
y = (word8)(n & 0xff);
if (o + 7 < 64) {
y &= 0x7f;
n >>= 7;
Expand Down
Loading