Repository navigation
Conversation
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11884
Scan targets checked: wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): tests/api/test_tls13.h
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_tls13.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
There was a problem hiding this comment.
🟡 Changes recommended
Deferred-response state remains inconsistent across mixed KeyUpdates, explicit updates, and shutdown.
3 open issues
What changed in this PR
This PR addresses KeyUpdate-flood denial of service in wolfSSL’s TLS 1.3 handling by coalescing responses while output is blocked.
Changes:
- Defer repeated KeyUpdate responses until pending output drains.
- Send deferred responses before new application data while respecting update limits.
- Add regression coverage for blocked writes and deferred-response handling.
| File | Description |
|---|---|
tests/api/test_tls13.h |
Declare and register the blocked-write regression test. |
tests/api/test_tls13.c |
Exercise KeyUpdate floods, write retries, and explicit updates. |
src/tls13.c |
Defer responses when TLS output is already buffered. |
src/internal.c |
Allow reads with deferred responses and adjust write-side response ordering. |
Review effort: Balanced
4f42dfd to
6d024a3
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11884
Scan targets checked: wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): tests/api/test_tls13.h
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_tls13.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11884
Fenrir already completed a review of this PR at commit 6d024a391d5e (run 3521); its findings are the review threads on the PR. Push a new commit to request another review.

Description
Fixes F-16278 to handle keyupdate flood
Testing
new test
Checklist