Repository navigation
Fix AVX512 Visual Studio assembly build. - #11853
Open
kareem-wolfssl wants to merge 1 commit into
Open
kareem-wolfssl wants to merge 1 commit into
kareem-wolfssl wants to merge 1 commit into
Conversation
Contributor
Author
|
@claude review |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The equivalent wolfssl-VS2022.vcxproj still omits the required AVX-512/VAES definitions and may fail with unresolved assembly references.
1 open issue
What changed in this PR
This pull request fixes Visual Studio x64 AVX-512/VAES assembly builds by passing feature definitions to MASM and clarifying ambiguous operand sizes in the Poly1305 and ChaCha assembly sources.
Changes:
- Adds configurable AVX-512 and VAES definitions to the Visual Studio assembly commands.
- Clarifies YMM-sized memory operands in Poly1305 assembly.
- Clarifies DWORD-sized
vmovdoperands in ChaCha assembly.
| File | Description |
|---|---|
wolfssl.vcxproj |
Passes AVX-512 and VAES definitions to relevant x64 MASM builds; the equivalent VS2022 project remains unupdated. |
wolfcrypt/src/poly1305_asm.asm |
Adds explicit YMM memory operand sizes for AVX-512 instructions. |
wolfcrypt/src/chacha_asm.asm |
Adds an explicit DWORD operand size to vmovd stores. |
Review effort: Lite
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
kareem-wolfssl
force-pushed
the
zd22620
branch
from
October 30, 2026 20:32
bb7b8c4 to
e434d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#22620
Testing
Confirmed solution built and ran test suite.
Checklist