Fix minor issues#966
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom May 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several small correctness issues in wolfSSH’s core packet/auth handling and client tooling by tightening bounds checks, fixing an invalid filesystem-close call, and preventing invalid memory accesses.
Changes:
- Fix file closing in
wolfSSH_ReadKey_file()by passing the correct filesystem context toWFCLOSE(). - Harden parsing/auth flow: handle empty algorithm-list strings safely and avoid dereferencing
ssh->ctx/ settingauthIdon failure in keyboard-interactive auth. - Correct ordering and bounds checks in packet bundling and fix a trailing Base64 padding check in fingerprint formatting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ssh.c |
Fixes WFCLOSE() call in wolfSSH_ReadKey_file() to use the correct filesystem argument. |
src/internal.c |
Adds safe empty-string handling in AlgoListSz(), corrects keyboard-interactive auth heap/authId handling, and reorders MAC buffer zeroing after bounds checks in BundlePacket(). |
apps/wolfssh/common.c |
Fixes trailing Base64 padding removal logic in FingerprintKey() without out-of-bounds access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following minor issues:
Addressed by f_215, f_216, f_406, f_407, f_408