Repository navigation
Conversation
Member
|
Please do not merge this until after 2.2 is released. |
Member
|
2.2 tagged, you may continue. |
Frauschi
reviewed
Oct 21, 2026
Frauschi
left a comment
Frauschi
left a comment
Member
There was a problem hiding this comment.
Thanks for splitting this up per finding, it made it easy to follow. The main concerns are compatibility: token keys stored with class -1 before this change become unusable, and CKM_HKDF_DATA without CKA_CLASS stops working. Both reproduced against master vs this branch. The rest are ordering, error code and test gaps.
Member
Author
|
looks like failures are from alpine upstream fyi |
Frauschi
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.