Repository navigation
Conversation
We're doing some oddities in our linker script that differ from what is done by default. To that end, we'd like to provide our own linker script so we don't have to carry patches forward
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Explicitly supplied LSCRIPT_IN values are still overwritten by later target and option assignments, so custom linker scripts are not reliably preserved.
1 open issue
What changed in this PR
This PR makes wolfBoot’s default linker-script input configurable, allowing custom layouts without patching the root Makefile.
Changes:
- Changes
LSCRIPT_INfrom an unconditional assignment (:=) to a conditional default (?=), preserving values already supplied through the environment or configuration.
| File | Description |
|---|---|
| Makefile | Makes the initial linker-script selection conditional. |
Review effort: Balanced
danielinux
approved these changes
Oct 28, 2026
Author
|
@danielinux I was planning on addressing the copilot review, but since you approved already, do you still need me to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We're doing some oddities in our linker script that differ from what is done by default. To that end, we'd like to provide our own linker script so we don't have to carry patches forward