Conversation
The nodes informer only handled Add/Update, so when a node was deleted its per-node pod watcher was never torn down. Each leaked node kept a blocked goroutine, a running pod informer (with its own clientset and watch connection), and a podStore entry holding every cached pod. In an autoscaled cluster with churning nodes this grows unbounded (~10 MiB/day observed in prod). Track each node's stop channel and add a DeleteFunc that closes it via a single stopNodeWatcher helper (close owned solely there, guarded by map membership under isHandling, so exactly-once). Also fixed two related issues in the same path: - Reserve the podStore slot synchronously under the lock so a burst of node updates can't spawn two watchers for one node. - Log-and-clean instead of logrus.Fatalf on pod-informer creation failure; a Fatal in the goroutine took down the whole controller and left every node tainted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nodes informer only handled Add/Update, so when a node was deleted its per-node pod watcher was never torn down. Each leaked node kept a blocked goroutine, a running pod informer (with its own clientset and watch connection), and a podStore entry holding every cached pod. In an autoscaled cluster with churning nodes this grows unbounded (~10 MiB/day observed in prod).
Track each node's stop channel and add a DeleteFunc that closes it via a single stopNodeWatcher helper (close owned solely there, guarded by map membership under isHandling, so exactly-once).
Also fixed two related issues in the same path: