Skip to content

Match Android typography to iOS font-size scale, fix unscaled text sizes - #682

Open
Mansimran Singh (Mansimran-Singh) wants to merge 1 commit into
mainfrom
feature/681/typography-parity
Open

Match Android typography to iOS font-size scale, fix unscaled text sizes#682
Mansimran Singh (Mansimran-Singh) wants to merge 1 commit into
mainfrom
feature/681/typography-parity

Conversation

@Mansimran-Singh

Copy link
Copy Markdown
Collaborator

Summary

  • Wires the keyboard's letter-key and typed-input text to their existing (but orphaned since the 2020 Compose rewrite) per-breakpoint dimens, instead of falling back to flat, non-scaling Material3 defaults
  • Fixes two similarly orphaned dimens on EditCategoryMenuScreen's title and SensitivityScreen's section labels/dwell-time value
  • Corrects settings_title_text_size's phone value (34sp→28sp) to match iOS's compact size (tablet already matched exactly)
  • Replaces the 6 genuine hardcoded fixed-size .sp literals with proper per-breakpoint dimens.xml entries
  • Font family (Roboto/San Francisco, each platform's own OS default) was already correct on both platforms and is unchanged

Ticket

Closes #681

Type of Change

  • Bug fix (unscaled text sizes, orphaned dimens from the Compose rewrite)
  • Accessibility/UX improvement (iOS parity)

Testing

  • ./gradlew compileDebugKotlin testDebugUnitTest — pass
  • ./gradlew assembleDebug assembleDebugAndroidTest — pass
  • No manual device/emulator verification in this environment

Checklist

  • Work-log added: Documentation/work-log/681-typography-parity.md
  • No new custom/bundled font introduced on either platform

🤖 Generated with Claude Code

Several screens fell back to flat Material3 defaults instead of this app's own
per-breakpoint dimens.xml convention, most notably the keyboard's letter-key and
typed-input text - traced via git blame to an orphaned dimen left behind by the
2020 Compose rewrite. Wires those (and two similarly orphaned dimens on
EditCategoryMenuScreen/SensitivityScreen) back in, corrects settings_title_text_size's
phone value to match iOS's compact size (tablet already matched), and gives the six
remaining genuine hardcoded text sizes proper per-breakpoint dimens. Font family
(Roboto/San Francisco, each platform's OS default) was already correct on both sides
and is unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match Android typography to iOS font-size scale, consolidate hardcoded text sizes

2 participants