Skip to content

Remove vendored throughput-forecast files; skill now installed globally - #673

Merged
troymyree-lang merged 1 commit into
feature/voice-selectionfrom
feature/666/remove-vendored-throughput-forecast
Aug 6, 2026
Merged

Remove vendored throughput-forecast files; skill now installed globally#673
troymyree-lang merged 1 commit into
feature/voice-selectionfrom
feature/666/remove-vendored-throughput-forecast

Conversation

@rhyslutsky

Copy link
Copy Markdown
Collaborator

Summary

Why

Per review feedback on #655/#666: rather than relocating gh_fetch.py into dq-documentation while still keeping project-specific copies vendored here, the whole skill (gather script + engine + config + docs) is now installed globally at ~/.claude/skills/github-throughput-forecast/ — available for any GitHub Projects v2 board, without committing anything into any one app's repo. PR #665 (the parent-breakdown follow-up) was closed unmerged rather than revised — its fixes were carried over into the global install directly.

Ticket

Closes #666 — same non-default-branch caveat as prior PRs in this thread: will manually close after merge since closes #N won't auto-fire against feature/voice-selection.

Type of Change

  • New feature
  • Bug fix
  • Refactor
  • Tests
  • CI/CD
  • Documentation

Testing

  • Unit tests added/updated — N/A, no app code touched
  • Integration tests added/updated — N/A
  • Manual testing performed — confirmed the global skill install at ~/.claude/skills/github-throughput-forecast/ works end-to-end after this removal (separate verification, not part of this repo's history)

Checklist

  • Tests pass locally (./gradlew testDebug) — N/A, no app code (app/) touched
  • No API keys or secrets in code — pure deletion
  • CLAUDE.md updated (if new pattern introduced) — not applicable, this removes a pattern rather than introducing one

See Documentation/work-log/666-remove-vendored-throughput-forecast.md for the full writeup.

Per review on #655/#666: rather than relocating gh_fetch.py to
dq-documentation while still vendoring project-specific copies here, the
whole skill is now installed at ~/.claude/skills/github-throughput-forecast/
instead - available for any GitHub Projects v2 board, nothing committed
into any one repo's history.

Removes .claude/scripts/{gh_fetch,forecast,forecast-html}.py,
.claude/skills/throughput-forecast/, and the settings.json that existed
solely for their Bash allowlist. create-ticket (#654/#656) untouched -
separate concern, out of scope. No merged history reverted - this is a
normal forward delete commit.

PR #665 closed unmerged rather than revised (its fixes carried over into
the global install already).

Closes #666

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 👍

@troymyree-lang troymyree-lang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — clean resolution of the skill-location thread. Deleting the vendored throughput-forecast files and installing the skill globally (~/.claude/skills/github-throughput-forecast/) is the right call: it works for any GitHub Projects board without committing into an app repo, create-ticket stays untouched, and #665's fixes were carried into the global install. Pure forward delete, no app code or secrets.

Merging via admin bypass since the org-required "Required Secret Scan (TruffleHog)" check is stuck pending (org-config issue — a public repo can't invoke the private-repo workflow), being routed to org admins separately.

@troymyree-lang
troymyree-lang merged commit 6b33b83 into feature/voice-selection Aug 6, 2026
2 checks passed
@troymyree-lang
troymyree-lang deleted the feature/666/remove-vendored-throughput-forecast branch August 6, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants