Repository navigation
Reject invalid view-model mapping contracts (SVL0006) - #14
Merged
wieslawsoltes merged 4 commits intoAug 11, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…lement-improvements-for-issue-10
wieslawsoltes
changed the title
…lement-improvements-for-issue-10 # Conflicts: # StaticViewLocator.Tests/StaticViewLocatorGeneratorSnapshotTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue scope
This PR does not fix issue #10, despite the branch name
codex/analyze-and-implement-improvements-for-issue-10. Issue #10 requestsAvalonia.Controls.ContentPageas a default view base type; this PR does not add or change default view base types.The PR has no linked or closing GitHub issue.
Actual scope
Validates
ViewModelMappingContractsentries instead of silently accepting closed generic types or ignoring malformed contracts.SVL0006at the locator declarationSVL0006in analyzer release tracking and documentationmainValidation
dotnet test StaticViewLocator.sln -c Release --nologo— 44 passeddotnet build StaticViewLocator.sln -c Release --nologo— succeeded with 0 warnings and 0 errorsdotnet format StaticViewLocator.sln --verify-no-changes --no-restore— passedgit diff --check— passed