Fix the crash on any key before Android 12; lint stops on newer APIs - #187
Merged
Merged
Conversation
1.4.0's screen saver told media keys apart with KeyEvent.isMediaSessionKey, which is Android 12+ (API 31): on Android 6 to 11 every key press crashed CastBay (seen on a Xiaomi TV, Android 6). The media keys are now listed in the app. What's New also read the language with Configuration.locales (Android 7+); it now uses ConfigurationCompat. Lint's NewApi check reported both, but nothing ran it: it is now fatal, and CI runs lintVitalRelease (as release builds already do), so a call above minSdk stops the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent fix for 1.4.0.
KeyEvent.isMediaSessionKey(added by the screen saver) only exists from API 31, so on Android 6–11 every key press crashes CastBay. This was reproduced on a Xiaomi TV running Android 6, and dropbox showsNoSuchMethodError.Configuration.locales(API 24) is replaced withConfigurationCompat.getLocales.NewApiis now fatal, and PR CI runs:app:lintVitalRelease. I checked that it fails on the old code.Tested on the Xiaomi TV (Android 6): key presses no longer crash. The crash report was then sent through the cast.weenas.com relay (CB-JP2RHT).
🤖 Generated with Claude Code