refactor(sctp): identify outbound messages independently of wire sequences - #253
Open
realzoberg wants to merge 1 commit into
Open
realzoberg wants to merge 1 commit into
realzoberg wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 87.85% 87.80% -0.05%
==========================================
Files 499 501 +2
Lines 72540 72646 +106
==========================================
+ Hits 63728 63790 +62
- Misses 8812 8856 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
realzoberg
force-pushed
the
split/237-03-reset-lifecycle
branch
from
September 21, 2026 21:51
7fad714 to
3a2692b
Compare
…ences Assign an association-local identity to each outbound message and use it to retire retained fragments and the pending tail together. Index only fragmented partially reliable messages, and verify whole-message candidates against their identity before abandonment. Extract the message-ownership groundwork from webrtc-rs#238 while preserving webrtc-rs#242's candidate-only retry checks and checked pending-queue retirement. Cover stale selections, cumulative-prefix removal and TSN wrap in the index.
realzoberg
force-pushed
the
split/237-03-reset-lifecycle
branch
from
September 21, 2026 23:04
3a2692b to
19e50c0
Compare
realzoberg
marked this pull request as ready for review
September 21, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outbound message abandonment currently locates retained fragments through TSN ranges and identifies pending tails through queue positions. Give each outbound message one association-local
MessageId, so its identity survives fragment removal and cannot refer to a later message that reuses the same wire TSN.The memory tradeoff is an 8-byte optional identity field per DATA chunk and an additional TSN index for fragmented, partially reliable messages. Index entries leave with cumulative acknowledgments; a single retained TSN is stored inline.