Repository navigation
Restructure package into a DDD module - #4
Merged
Merged
Conversation
Move the three sub-contexts (Identity, Authentication, Authorization) under src/Context/* and update all namespaces to Webify\User\Context\*. Relocate application-layer use cases (RegisterUser, OpenSession, VerifyChallenge, AssignRole, CreateRole, etc.) and strategies out of Domain/Service into Application/, where use cases that orchestrate repositories, hashers, ID generators, and event publishers belong. Consolidate value objects that were duplicated and had diverged across contexts into the shared kernel (src/Domain): UserId, UserStatus, and PasswordHash. Add UserStatus::Unverified and remove the now-redundant Authentication copies and UserStatusTranslator. Give the ExtensionInterface entry point a home in src/Infrastructure/Extension/UserExtension and add per-context ServiceDefinitions. Also: - Wire a PHPat DomainSpecification into PHPStan (raised to level 10) - Mirror the src/ layout in test/Unit and add UserExtensionTest - Add docs/refactor.md documenting the refactor and composer.local.json Signed-off-by: Mohammed Shifreen <mshifreen@gmail.com>
Contributor
Author
|
The pr-check failed due to unit tests failure because some classes which comes from the base extension were missing and it expected because the base extension needs to be pushed it's latest changes. So this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the three sub-contexts (Identity, Authentication, Authorization) under src/Context/* and update all namespaces to Webify\User\Context*.
Relocate application-layer use cases (RegisterUser, OpenSession, VerifyChallenge, AssignRole, CreateRole, etc.) and strategies out of Domain/Service into Application/, where use cases that orchestrate repositories, hashers, ID generators, and event publishers belong.
Consolidate value objects that were duplicated and had diverged across contexts into the shared kernel (src/Domain): UserId, UserStatus, and PasswordHash. Add UserStatus::Unverified and remove the now-redundant Authentication copies and UserStatusTranslator.
Give the ExtensionInterface entry point a home in
src/Infrastructure/Extension/UserExtension and add per-context ServiceDefinitions.
Also: