feat(cc): add campaign preview by cmullenx · Pull Request #684 · webex/widgets

cmullenx · 2026-05-11T20:32:40Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7660 and https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7662

This pull request addresses

Adds the UI for the campaign preview functionality

by making the following changes

creates new components for campaign preview
creates global variable component to share between call control cad and campaign components
makes changes to call control cad to render campaign preview ui
adds campaign preview to task list only when flag is enabled

Figma: https://www.figma.com/design/JvnDPHRIXlvZEiSSCBwtjk/WxCC-6242---Preview-Campaign?node-id=6473-173114&m=dev

Vidcast: https://app.vidcast.io/share/72f03823-417d-4417-8a5a-35032943f3d3

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
Can accept campaign previews
Can skip campaign previews
Can remove campaign previews
Can disable skip/remove buttons based on campaign settings
Campaign auto action fires when campaign times out

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3cda98967

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aws-amplify-us-east-2 · 2026-05-11T20:40:17Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-684.d1b38q61t1z947.amplifyapp.com

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a2feebe73

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 003596fba6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-11T21:33:20Z

+  const globalVariablesRef = useRef(latestGlobalVariables);
+  if (latestGlobalVariables.length > 0) {
+    globalVariablesRef.current = latestGlobalVariables;
+  }


Reset campaign CAD when a new preview contact arrives

When Skip/Remove advances the same campaign task to another contact and the SDK update omits or empties callAssociatedData, this ref never clears because it only writes non-empty values. The component already detects new contacts via timeoutTimestamp below, but GlobalVariablesPanel will keep showing the previous contact's global variables on the next preview; reset/key the ref when the offer changes, and mirror the same fix in the popover path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97c2c9dd1a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Shreyas281299

Partial review.

bhabalan · 2026-05-18T05:47:33Z

+};
+
+const CampaignTaskWithMetrics = withMetrics(CampaignTask, 'CampaignTask');
+export default CampaignTaskWithMetrics;


Should we wrap this with ErrorBoundary too? The other task components all have it and if something blows up in here it'd take down the whole TaskList.

i added an ErrorBoundary to where CampaignTask is rendered

bhabalan · 2026-05-18T05:47:33Z

@@ -648,6 +741,36 @@ class StoreWrapper implements IStoreWrapper {
    this.refreshTaskList();
  };



nit: event is untyped here — should be ITask like the other handlers.

should be resolved

bhabalan · 2026-05-18T05:47:33Z

+        setIsAcceptClicked(true);
+        setHandleTimestamp(Date.now());
+        disableAllButtons();
+        logger?.info('CC-Widgets: CampaignTask: Auto-accept UI state set, awaiting backend', {


nit: This useState is way down here after a bunch of useEffects. Easy to miss — mind moving it up with the rest of the state declarations?

there isn't a useState down here

…callcontrols render

Shreyas281299 · 2026-05-22T05:22:06Z

+  // Persist global variables across task updates — some store refreshes
+  // replace the task with a snapshot that omits callAssociatedData,
+  // which causes getAgentViewableGlobalVariables to return [].
+  // We intentionally keep the previous values when length === 0 because
+  // an empty array indicates missing data, not a legitimate clearing of
+  // variables.  Variables are never cleared mid-call by the backend.
+  const globalVariablesRef = useRef(latestGlobalVariables);
+  if (latestGlobalVariables.length > 0) {
+    globalVariablesRef.current = latestGlobalVariables;
+  }
+  const globalVariables = globalVariablesRef.current;


If we need to persist variables across refrershed then ideally we should put the value in the store. But if its working then we dont need to make any changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1406aa2787

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97626ebe20

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca1781fcfc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac283aedbe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2cc5df298

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-22T14:27:25Z

+                      </div>
+                    )}
+
+                    {selectedWidgets.callControlCAD && (


Restore current-task guard before mounting CallControlCAD

This branch now mounts CallControlCAD even when store.currentTask is null, but CallControlCADComponent still dereferences currentTask.data before its null check, so toggling the CAD widget with no active interaction can throw and repeatedly trip the error boundary. Keeping the previous store.currentTask gate here (or moving the null guard ahead of all dereferences in the component) avoids a startup/between-calls crash path in the sample app.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c620507371

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-22T15:03:20Z

+      if (this.isCampaignPreview(task) && task.data.interaction.state === 'new') {
+        this.setState({
+          developerName: RESERVED_LABEL,
+          name: RESERVED_USERNAME,
+        });


Keep accepted preview assignments out of RESERVED state

handleTaskAssigned sets any campaign preview with interaction.state === 'new' to RESERVED, but accepted previews can remain in 'new' during SDK state lag (the same lag this change already handles via acceptedCampaignIds in setCurrentTask). In that window, an accepted preview can trigger task:assigned and this branch overwrites ENGAGED with RESERVED, so the agent state is incorrect while the accepted preview is active. Use the accepted-campaign guard here as well (for example, only set RESERVED when the interaction is 'new' and not in acceptedCampaignIds).

Useful? React with 👍 / 👎.

Shreyas281299

Minor changes required for the tests to use await while rendering. And removing a file. Please add await in all the tests before merging

Shreyas281299 · 2026-05-27T08:36:28Z

Can we remove this file

Shreyas281299 · 2026-05-27T08:37:29Z

+};
+
+const renderComponent = (overrides: Partial<CampaignTaskListItemProps> = {}) =>
+  render(<CampaignTaskListItem {...defaultProps} {...overrides} />);


I dont see these changes

Shreyas281299 · 2026-05-27T08:38:33Z

+    renderComponent({isAcceptClicked: false});
+    expect(screen.getByTestId('campaign-popover-accept-button')).toBeInTheDocument();


We have used await in some tests and some we dont. Can we use await while rendering all the time

cmullenx requested a review from a team as a code owner May 11, 2026 20:32

cmullenx added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels May 11, 2026

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread packages/contact-center/cc-components/src/components/task/TaskList/task-list.tsx

Comment thread packages/contact-center/cc-components/src/components/task/CampaignTask/campaign-task.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread packages/contact-center/cc-components/src/components/task/CallControlCAD/call-control-cad.tsx

Comment thread packages/contact-center/store/src/storeEventsWrapper.ts

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread packages/contact-center/store/src/storeEventsWrapper.ts Outdated

Shreyas281299 reviewed May 19, 2026

View reviewed changes

bhabalan reviewed May 19, 2026

View reviewed changes

Christina Mullen added 6 commits May 20, 2026 15:55

feat(cc): add campaign preview

b083765

remove dead code

8fce80b

update based on codex pr comment

78d5e70

update based on codex pr comment

e9850ce

fix popover styling issue and put campaign in connecting state until …

b778abb

…callcontrols render

update based on pr comments

e8a783a

cmullenx force-pushed the chrmulle/campaignPrev branch from 97c2c9d to e8a783a Compare May 20, 2026 22:12

Shreyas281299 requested changes May 22, 2026

View reviewed changes

update pr comments

1406aa2

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread packages/contact-center/store/src/storeEventsWrapper.ts Outdated

Christina Mullen added 2 commits May 22, 2026 07:31

more pr comments

c0f241f

more pr review changes

97626eb

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread packages/contact-center/task/src/CallControlCAD/index.tsx

Comment thread packages/contact-center/store/src/storeEventsWrapper.ts Outdated

pr changes

ca1781f

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread packages/contact-center/task/src/CallControlCAD/index.tsx

more pr fixes

ac283ae

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread packages/contact-center/store/src/storeEventsWrapper.ts Outdated

address codex comment

a2cc5df

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

pr fix

c620507

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Shreyas281299 approved these changes May 27, 2026

View reviewed changes

bhabalan approved these changes May 27, 2026

View reviewed changes

		@@ -648,6 +741,36 @@ class StoreWrapper implements IStoreWrapper {
		this.refreshTaskList();
		};

		renderComponent({isAcceptClicked: false});
		expect(screen.getByTestId('campaign-popover-accept-button')).toBeInTheDocument();

Conversation

cmullenx commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7660 and https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7662

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aws-amplify-us-east-2 Bot commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Shreyas281299 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cmullenx commented May 11, 2026 •

edited

Loading