Wiser-Frontend Developer Test completed By Tian Liu - #12
Open
hnamdev008 wants to merge 3 commits into
Open
hnamdev008 wants to merge 3 commits into
hnamdev008 wants to merge 3 commits into
Conversation
Test code-base complete
Updated README
johnfedoruk
reviewed
Jul 27, 2018
johnfedoruk
left a comment
johnfedoruk
left a comment
Collaborator
There was a problem hiding this comment.
Automated Testing:
- Lint: fails
- Test: fails
- Coverage: fails
- Build: fails
Manual Review
- No demonstration of Angular animation implementation
- Good use of services
- Has auth guards
- No readme describing changes
- Good use of form logic
- No lazy loading
- No application modules
- Has shared module for auth service
- Authentication broken (refresh doesn't work)
- Using promises, but no async
- Use of local storage for a JWT is a security vulnerability.
- Good directory structure
- Would like to see more typescript features (privacy modifiers / return types / type setting)
| "tslint": "~5.9.1", | ||
| "typescript": "~2.5.3" | ||
| "typescript": "~2.5.3", | ||
| "jwt-decode": "2.2.0", |
| }, | ||
| { | ||
| path: 'secure', | ||
| component: SecureComponent, |
Collaborator
There was a problem hiding this comment.
This is supposed to be lazy loaded
| path: 'error/:status_code', | ||
| component: ErrorComponent | ||
| }, | ||
| { |
Collaborator
There was a problem hiding this comment.
The paths /auth/login and auth/logout are supposed to be handled by a distinct application module
| { | ||
| path: 'secure', | ||
| component: SecureComponent, | ||
| canActivate: [AuthGuard] |
| #password="ngModel" | ||
| id="password" | ||
| class="w3-input ng-untouched ng-pristine ng-valid" name="password" type="password" /> | ||
| <div [hidden]="password.valid || password.pristine" class="alert alert-danger"> |
| export class AuthService { | ||
|
|
||
| _baseURL = "https://dev-test-service.madebywiser.com"; | ||
| _userName = ""; |
Collaborator
There was a problem hiding this comment.
Should have a privacy modifier of private
| @Injectable() | ||
| export class AuthService { | ||
|
|
||
| _baseURL = "https://dev-test-service.madebywiser.com"; |
Collaborator
There was a problem hiding this comment.
Should have a privacy modifier of private
| localStorage.setItem(username, JSON.stringify({ username: username, token: data })); | ||
|
|
||
| this.profile$.next({ | ||
| username: username; |
Collaborator
There was a problem hiding this comment.
Using semi-colons does not comply with JSON standards.
| .then((data)=> | ||
| { | ||
| this._userName = username; | ||
| localStorage.setItem(username, JSON.stringify({ username: username, token: data })); |
Collaborator
There was a problem hiding this comment.
Using localStorage is a security vulnerability - should be using sessionStorage
| private authService: AuthService) {} | ||
|
|
||
| canActivate() { | ||
| if (!this.authService.isTokenExpired()) { |
Collaborator
There was a problem hiding this comment.
This does nothing to help in the situation in which the window is refreshed. Also, it doesn't validate that the token has been signed by the server after performing a login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.