Repository navigation
6.0: ContractDetails event-contract fields; drop #[non_exhaustive] - #1251
Merged
Merged
Conversation
Decode eventContract1 / eventContractDescription1 / 2 as event_contract_topic / description / question (live ForecastEx data). A live probe found minAlgoSize "0" everywhere and the precision fields only on AAPL with unclear meaning, so neither is added. With nothing left to come, #[non_exhaustive] comes off ContractDetails and TickRequestParameters before 6.0 ships; migration §35 rewritten.
…directive - #[serde(default)] on the three event-contract fields, with a test that JSON without them deserializes; §35 says so - TickReqParams precision fact moved to market-data.md; rustdoc cites entries by anchor and reads as user guidance - restrict-after-callers: probe-first directive in the node body - prose matches the field name (description, not label)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1232 marked
ContractDetailsandTickRequestParameters#[non_exhaustive]so a 6.x release could add fields TWS sends but the decoder drops:minAlgoSize, last price/size precision, and the ForecastEx event-contract strings. B3 items 2–3 checked those fields against a live gateway before adding them:minAlgoSize"0""0.000001"/"0.000001""0""0"minAlgoSizewas"0"on every row, including AAPL, which takes algo orders, so it's skipped.minTick(0.01) andminSize(0.0001), and nothing documents what they govern. Also skipped.TickReqParamsmatched this.With no field left to add, the attribute has no justification under the restrict-after-callers rule. Like
ScannerDatain #1234, it comes off before 6.0 ships.What
ContractDetails::event_contract_topic,event_contract_descriptionandevent_contract_question(IBKR'seventContract1,eventContractDescription1andeventContractDescription2), decoded and covered by a table test that uses the live values.#[non_exhaustive]removed fromContractDetailsandTickRequestParameters. The type docs say why the remaining proto fields aren't decoded.non_exhaustive, only the three new fields, which break a struct literal or pattern that names every field. The number is kept because 6.0: one set of tick types for tick_by_tick and historical_ticks #1244 already uses §39.Changedentry is removed and anAddedentry is new.docs/wire-facts/contracts.mdentry with the probe table.restrict-after-callersprecedent records that 6.0: ContractDetails, ScannerData, TickRequestParameters are #[non_exhaustive] #1232 was fully reversed.Verified
ContractDatacapture walked field by field, 2026-11-15 23:52 ET.just test, integration crate clippy,just rules-check.