-
Notifications
You must be signed in to change notification settings - Fork 0
Codex/dependency gate break test #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
warheart1984-ctrl
wants to merge
2
commits into
main
Choose a base branch
from
codex/dependency-gate-break-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: Dependency Gate | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
|
|
||
| jobs: | ||
| dependency-check: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
|
|
||
| - name: Install frontend deps (clean) | ||
| working-directory: frontend | ||
| run: npm ci | ||
|
|
||
| - name: Audit frontend | ||
| working-directory: frontend | ||
| run: npm audit --audit-level=moderate | ||
|
|
||
| - name: Test frontend | ||
| working-directory: frontend | ||
| run: npm run test:ci | ||
|
|
||
| - name: Build frontend | ||
| working-directory: frontend | ||
| run: npm run build | ||
|
|
||
| - name: Install mobile deps (clean) | ||
| working-directory: mobile | ||
| run: npm ci | ||
|
|
||
| - name: Audit mobile | ||
| working-directory: mobile | ||
| run: npm audit --audit-level=moderate | ||
|
|
||
| - name: Typecheck mobile | ||
| working-directory: mobile | ||
| run: npm run typecheck | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Install uv | ||
| run: pip install uv | ||
|
|
||
| - name: Sync root deps | ||
| run: uv sync --frozen --extra dev | ||
|
|
||
| - name: Sync api deps | ||
| working-directory: api | ||
| run: uv sync --frozen | ||
|
|
||
| - name: Run backend tests | ||
| run: uv run --frozen pytest -q | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| # Dependency Overrides | ||
|
|
||
| This file explains the remaining npm overrides that are still admitted into | ||
| AAIS after the dependency hardening pass. | ||
|
|
||
| Overrides are not normal dependency state. | ||
| They are temporary governance shims that stay only while an upstream tree still | ||
| resolves an unsafe version. | ||
|
|
||
| ## Current Rule | ||
|
|
||
| - keep an override only when a clean no-override resolution reintroduces a | ||
| vulnerable or explicitly rejected package version | ||
| - remove an override as soon as upstream resolves to a safe version without it | ||
| - record the reason and expected removal condition here | ||
|
|
||
| ## Frontend | ||
|
|
||
| The frontend no longer requires overrides. | ||
|
|
||
| An isolated no-override resolution on 2026-04-29 still produced: | ||
|
|
||
| - `follow-redirects 1.16.0` | ||
| - `lodash 4.18.1` | ||
| - `postcss 8.5.12` | ||
|
|
||
| and `npm audit --audit-level=moderate --package-lock-only` reported | ||
| `0 vulnerabilities`. | ||
|
|
||
| That is why the frontend override block was removed. | ||
|
|
||
| ## Mobile | ||
|
|
||
| The mobile package still requires three overrides today because the Expo 54 | ||
| dependency tree reintroduces unsafe versions without them. | ||
|
|
||
| ### `@xmldom/xmldom` | ||
|
|
||
| - reason: the no-override tree resolves `@xmldom/xmldom 0.8.13` on the Expo | ||
| config path, while the governed floor is `0.9.10` | ||
| - current admitted override: `0.9.10` | ||
| - remove when: the Expo / plist / config-plugin tree resolves `>=0.9.10` | ||
| natively | ||
|
|
||
| ### `postcss` | ||
|
|
||
| - reason: the no-override tree resolves `postcss 8.4.49`, and | ||
| `npm audit --audit-level=moderate --package-lock-only` reports the | ||
| moderated-severity advisory on versions `<8.5.10` | ||
| - current admitted override: `8.5.12` | ||
| - remove when: the Expo Metro/config tree resolves `>=8.5.10` natively | ||
|
|
||
| ### `uuid` | ||
|
|
||
| - reason: the no-override tree resolves `uuid 7.0.3` through `xcode`, and | ||
| `npm audit --audit-level=moderate --package-lock-only` reports the | ||
| moderated-severity advisory on versions `<14.0.0` | ||
| - current admitted override: `14.0.0` | ||
| - remove when: the Expo config-plugin / xcode tree resolves `>=14.0.0` | ||
| natively | ||
|
|
||
| ## Removed Override | ||
|
|
||
| ### `follow-redirects` (mobile) | ||
|
|
||
| - result: removed | ||
| - reason: the no-override mobile tree already resolves `follow-redirects | ||
| 1.16.0`, so the override was no longer carrying real governance weight | ||
|
|
||
| ## Verification Evidence | ||
|
|
||
| The 2026-04-29 no-override probe used isolated temporary installs outside the | ||
| live package folders, then checked: | ||
|
|
||
| - frontend `npm audit --audit-level=moderate --package-lock-only` | ||
| - mobile `npm audit --audit-level=moderate --package-lock-only` | ||
|
|
||
| The frontend passed cleanly without overrides. | ||
| The mobile tree failed without overrides and justified the remaining three. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| "node": ">=18" | ||
| }, | ||
| "dependencies": { | ||
| "axios": "1.15.2", | ||
| "axios": "1.14.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When the new dependency gate runs, Prompt To Fix With AIThis is a comment left during a code review.
Path: frontend/package.json
Line: 9
Comment:
**Frontend lockfile is out of sync**
When the new dependency gate runs, `package.json` requests axios 1.14.0 while `package-lock.json` still records 1.15.2, so `npm ci` rejects the inconsistent files before the frontend audit, tests, and build can run.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-hot-toast": "^2.4.0", | ||
|
|
@@ -55,10 +55,5 @@ | |
| "last 1 firefox version", | ||
| "last 1 safari version" | ||
| ] | ||
| }, | ||
| "overrides": { | ||
| "follow-redirects": "1.16.0", | ||
| "lodash": "4.18.1", | ||
| "postcss": "8.5.12" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow resolves checkout, setup-node, and setup-python through mutable major-version tags, allowing upstream tag movement to change the CI code executed without a reviewed repository change; pinning full commit SHAs would make the dependency gate reproducible.
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!