Repository navigation
Address review findings (data consistency, timezone, age, threshold copy, types:check) - #4
Merged
Merged
Conversation
…old copy, types:check 1. MoveAnimal rejects a moved_at earlier than the animal's latest movement, so current_paddock_id can never disagree with the history. Errors surface on the moved_at field; tests cover reject, equal timestamp and the HTTP path. 2. app.timezone now reads APP_TIMEZONE. The farm timezone, today's date in that timezone and the warning threshold are shared as Inertia props; date pickers use the server's "today" instead of the browser's UTC date, and the move dialog states which timezone the timestamp is in. 3. Animal::ageLabel() reports whole years/months/days only; the date-of-birth has no time component. Unit-tested at boundaries. 4. Dashboard copy uses the configured warning percentage. 5. npm run types:check generates Wayfinder files first so it works on a fresh clone (.npmrc has ignore-scripts, so pre-hooks do not run). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the five findings from the review:
MoveAnimalnow rejects amoved_atearlier than the animal's latest movement (error on the date field), with tests for reject / equal timestamp / HTTP path.config/app.phpreadsAPP_TIMEZONE; the farm timezone, today's date in that timezone and the warning threshold are shared Inertia props. Date pickers no longer use the browser's UTC date; the move dialog labels the timezone.7m 4d, never hours); unit tests at boundaries..npmrchasignore-scripts, so an npm pre-hook would not run).composer ci:checkpasses locally: 91 tests, PHPStan level 7 clean, formatting clean.🤖 Generated with Claude Code