Repository navigation
First draft of report extension for infos on matched nodes #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robert-david
wants to merge
10
commits into
gh-pages
Choose a base branch
from
issue-1221-report-extension
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c927e9
First draft of report extension for infos on matched nodes
robert-david 0a17757
Added shacl.ttl for shape assignment vocabulary + minor adjustments t…
robert-david 5da5464
Clarified the node grounding + added disjointness of sh:ValidationRes…
robert-david 8bf0cec
Merge branch 'gh-pages' into issue-1221-report-extension
robert-david 1cc07dd
Moved disjointness statement from shacl.ttl (OWL) to shac-shacl.ttl (…
robert-david ec7c6a7
Fixed typos and style
robert-david dbd1f84
Removed invalid and redundant use of sh:conforms for sh:ShapeAssignment
robert-david eca6daa
Provided an example for sh:ShapeAssignment
robert-david b272c05
Removed 'grounding' and clarified how target nodes are determined
robert-david ef0d655
Removed 'grounding' and clarified how target nodes are determined
robert-david File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2518,6 +2518,26 @@ <h3>Validation Report</h3> | |
| </div> | ||
| </aside> | ||
|
|
||
| <p> | ||
| A validation report MAY optionally provide information on shape assignments to focus nodes. | ||
| The following graph represents an example of a validation report for the validation of a data graph that provides shape ssignment information. | ||
| </p> | ||
| <aside class="example" title="Example of a validation report providing shape assignment information"> | ||
| <div class="results-graph"> | ||
| <div class="turtle"> | ||
| [ a sh:ValidationReport ; | ||
| sh:conforms true ; | ||
| sh:nodeAssignmentCount 1 ; | ||
| sh:assignment [ | ||
| a sh:ShapeAssignment ; | ||
| sh:focusNode ex:Bob ; | ||
| sh:sourceShape ex:PersonShape-age ; | ||
| ] | ||
| ] . | ||
| </div> | ||
| </div> | ||
| </aside> | ||
|
|
||
| <section id="results-validation-report"> | ||
| <h4>Validation Report (sh:ValidationReport)</h4> | ||
| <p> | ||
|
|
@@ -2619,6 +2639,26 @@ <h5>Processor Configuration (sh:ProcessorConfiguration)</h5> | |
| maximum recursion depth, or other runtime parameters. | ||
| </p> | ||
| </section> | ||
| <section id="nodeAssignmentCount"><!-- ISSUE-1221 --> | ||
| <h5>Node Assignment Count (sh:nodeAssignmentCount)</h5> | ||
| <p> | ||
| A validation report MAY contain one value for the property <code>sh:nodeAssignmentCount</code>. | ||
| The value MUST be equal to the total number of shape assignments of a <a>shape</a> to a <a>focus node</a> | ||
| declared or produced by a <a href="#targets">target declaration</a>. | ||
| </p> | ||
| <p class="informative"> | ||
| For example, target declarations of <a href="#targetNode"><code>sh:targetNode</code></a> directly specify the target nodes, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possible editorial nit: Isn't "For example"-style text put after a "The remainder of this section is informative" divider? |
||
| whereas the target nodes of a <a href="#targetClass"><code>sh:targetClass</code></a> target declaration are the SHACL instances of the specified class. | ||
| </p> | ||
| </section> | ||
| <section id="assignment"><!-- ISSUE-1221 --> | ||
| <h5>Assignment (sh:assignment)</h5> | ||
| <p> | ||
| A validation report MAY containt values for the property <code>sh:assignment</code>. | ||
| If it does, it MUST provide one value for every pair of <a>shape</a> and <a>focus node</a> declared or produced by a <a href="#targets">target declaration</a>. | ||
| Each value of <code>sh:assignment</code> is a SHACL instance of the class <code>sh:ShapeAssignment</code>. | ||
| </p> | ||
| </section> | ||
| </section> | ||
|
|
||
| <section id="results-validation-result"> | ||
|
|
@@ -2711,6 +2751,15 @@ <h4>Severity (sh:resultSeverity)</h4> | |
| </ol> | ||
| </section> | ||
| </section> | ||
| <section id="results-shape-assignment"><!-- ISSUE-1221 --> | ||
| <h4>Validation Details (sh:ShapeAssignment)</h4> | ||
| <p> | ||
| SHACL defines <code>sh:ShapeAssignment</code> to report individual assigmments of a <a>focus node</a> to a <a>shape</a>. | ||
| Each instance of <code>sh:ShapeAssignment</code> MUST have exactly one value for the property <code>sh:focusNode</code> | ||
| and exactly one value for the property <code>sh:sourceShape</code>. | ||
| <code>sh:ShapeAssignment</code> is disjoint with <code>sh:ValidationResult</code>. | ||
| </p> | ||
| </section> | ||
| </section> | ||
|
|
||
| <section id="value-nodes"> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the relationship between this class and its sibling
sh:ValidationResult? Is aValidationResultimplicitly aShapeAssignment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, never (i.e., classes are disjoint, to be encoded in SHACL-SHACL)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather never, i guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added disjointness statement to the shacl.ttl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, except shacl.ttl purposefully doesn't use most
owl:concepts. Better to leave a firm statement in therdfs:comment, and updateshacl-shacl.ttlas part of this PR's changes.