fix: Native AOT crash when opening column filter flyout - #432
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
XamlParseExceptionthat occurs when opening the column filter flyout in Native AOT applications.TableViewFilterMenuFlyout.Itemswas exposed asIList<MenuFlyoutItemBase>. Under CsWinRT / Native AOT, this can be projected asIVector<MenuFlyoutItemBase>, which fails when XAML adds derivedMenuFlyoutItemandMenuFlyoutSeparatorinstances to the collection.This changes the property type to the concrete
List<MenuFlyoutItemBase>, allowing the flyout items to be created correctly in Native AOT builds.Related Issue
Closes #422
Type of Change
Checklist
mainbranchScreenshots / Recordings
Not applicable.
Additional Notes
This is a one-line type change from
IList<MenuFlyoutItemBase>toList<MenuFlyoutItemBase>and does not change the behavior of the filter flyout outside of resolving the Native AOT collection projection issue.