Improve copy performance and reject conflicting configuration - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy status repeatedly traversed nested subtrees and loaded whole files into memory. It now visits each directory tree once, compares file sizes before reading bounded chunks, and streams file copies. Small files use smaller buffers.
Configuration now rejects extra YAML documents (including malformed or empty trailing documents) and exact normalized target collisions among repositories, copies, symlinks/groups, SSH private/public keys, and asdf tool-version files. Directory prerequisites and parent/child targets remain allowed. Ownership checks are lexical; filesystem aliases and overlapping directory contents are outside their scope.
Includes behavioral regressions, reusable nested/large-file benchmarks, and updated docs.
Performance evidence
Local synthetic measurements used the same temporary benchmark before/after, three iterations per case; these are not production latency guarantees.
Permanent benchmarks:
go test ./internal/resources -run '^$' -bench 'BenchmarkCopy' -benchmem.Verification
make release-check(formatting, full tests, vet, build, distribution smoke test)git diff --checkThe local login-shell smoke check was skipped because the host could not report
UserShell. Go checks used a writable temporary cache due to sandbox restrictions.Safety
Documentation
Separate follow-ups: #6 (subprocess inspections) and #7 (bounded log capture).