Skip to content

Remove @translatableV2 from Category (catalog-dataplane) - #175

Merged
renatoalmeidav merged 2 commits into
masterfrom
chore/remove-category-translatable-dataplane
Sep 23, 2026
Merged

renatoalmeidav merged 2 commits into
masterfrom
chore/remove-category-translatable-dataplane

Conversation

@renatoalmeidav

@renatoalmeidav renatoalmeidav commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove @translatableV2 from Category.name, titleTag, and metaTagDescription (same schema change as [CATS-4817] Remove @translatableV2 from Category fields #172, after yanking 0.73.0).
  • Changelog notes that vtex.search-resolver now loads categoryTree from catalog-dataplane (GET /api/catalog-dataplane/product/{id}), which returns these strings already translated — Messages must not wrap them again.

Companion resolver: vtex-apps/search-resolver#612. Publish both apps together. (search-resolver should be executed first)

Test plan

  • Query product { categoryTree { name titleTag metaTagDescription } } on a localized binding and confirm catalog-dataplane locale values (no Messages encoding, no second translation).
  • Confirm Brand and other @translatableV2 fields are unchanged.
  • Link against search-resolver with the catalog-dataplane categoryTree change.

Made with Cursor

Category tree values now come already translated from catalog-dataplane, so Messages must not wrap them a second time.

Co-authored-by: Cursor <cursoragent@cursor.com>
@renatoalmeidav
renatoalmeidav requested a review from a team as a code owner September 16, 2026 13:43
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

vtex-io-docs-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@renatoalmeidav
renatoalmeidav merged commit 2369f22 into master Sep 23, 2026
6 checks passed
@renatoalmeidav
renatoalmeidav deleted the chore/remove-category-translatable-dataplane branch September 23, 2026 15:05
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Sep 23, 2026

Copy link
Copy Markdown

Your PR has been merged! App is being published. 🚀
Version 0.74.0-beta.0 → 0.74.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-graphql@0.74.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants