Repository navigation
[as-1069] Add asdf and pre-commit caches - #8
Merged
Merged
Conversation
…cache on merge to main (to speed up installs). chore(workflows): update names of asdf-dependabot-update workflow steps. chore(pr-template): add priority to rationale. chore(workflows): replace existing usage of asdf install to use new action (with cache for speedups).
|
@kevin-dimichel , I haven't looked much into it, but is this check expected to fail? |
Contributor
Author
|
@mo-getter - No. This and other public repos are failing. I'm working on a fix. |
kevin-dimichel
marked this pull request as draft
January 30, 2026 18:03
…epos pre-commit (by removing duplicate steps).
chore: tune pre-commit configs.
kevin-dimichel
marked this pull request as ready for review
February 5, 2026 21:58
Contributor
Author
|
@mo-getter - The fix is in!! |
mo-getter
requested changes
Feb 5, 2026
mo-getter
left a comment
mo-getter
left a comment
There was a problem hiding this comment.
Nice workaround for the GitHub limitation--very clever!
Looks good--just one thing about package.json since this is the plugin skeleton we recommend to the community.
… artibrary ordering.
…Add to pretty-format-json exclude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Aloha would like to speed up our pre-commit and asdf PR checks through caches.
In https://github.com/voxel51/aloha-github-workflows/pull/52 we added two new custom actions for pre-commit and asdf to leverage GitHub caches.
Review Priority
Changes
update-asdfjob when matrix is empty ('[]')It appears that pre-commit was never running (successfully) locally or via actions. This PR includes file fixes and pre-commit config tuning.
Testing
See PR check.