-
Notifications
You must be signed in to change notification settings - Fork 166
fix(cli): prevent TTY hang during command delegation (#1396) #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Han5991
wants to merge
7
commits into
voidzero-dev:main
Choose a base branch
from
Han5991:fix/1396-lefthook-tty-hang
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−1
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
292f5cf
fix(cli): prevent TTY hang during command delegation by removing eage…
Han5991 7846dd6
test: update lint-vite-plus-imports snap
Han5991 ed3de8e
fix(cli): remove extra newline in help output to prevent TTY hang
Han5991 09210c6
fix(cli): restore top-level help header
Han5991 95d7170
fix(cli): disable header display in CLI argument parsing to prevent T…
Han5991 3ee3a11
fix(header): bound tty color query wall-clock wait
Han5991 22978f1
chore(cli): drop header workaround changes
Han5991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query_terminal_colorsnow returns after a fixed 250ms timeout, but the spawnedquery_terminal_colors_innerpath can keep/dev/ttyin raw mode for up to 1000ms whenSSH_CONNECTION/SSH_TTYis set. If the outer timeout fires first, the caller continues while the detached thread still owns terminal mode changes, so delegated/interactive commands can start with a raw tty and exhibit input/editing glitches or apparent hangs. This regression is introduced by the new async wrapper and should be fixed by making the outer timeout cover the inner worst-case window (or by preventing raw-mode mutation in a detached worker).Useful? React with 👍 / 👎.