Skip to content

Commit 87aa125

Browse files
Copilotfengmk2
andauthored
chore: make "Disable Windows Defender" step non-blocking in E2E workflow (#1397)
The scheduled E2E run failed because the "Disable Windows Defender" PowerShell step errored, causing all subsequent steps to be skipped. This is a performance optimization, not a prerequisite. - Add `continue-on-error: true` to both "Disable Windows Defender" steps in `.github/workflows/e2e-test.yml` (build job and e2e-test job) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
1 parent 87c1aa5 commit 87aa125

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/e2e-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ jobs:
8383
# Disable Windows Defender real-time scanning to speed up I/O-heavy builds (~30-50% faster)
8484
- name: Disable Windows Defender
8585
if: runner.os == 'Windows'
86+
continue-on-error: true
8687
shell: powershell
8788
run: Set-MpPreference -DisableRealtimeMonitoring $true
8889

@@ -344,6 +345,7 @@ jobs:
344345
# Disable Windows Defender real-time scanning to speed up I/O-heavy operations
345346
- name: Disable Windows Defender
346347
if: runner.os == 'Windows'
348+
continue-on-error: true
347349
shell: powershell
348350
run: Set-MpPreference -DisableRealtimeMonitoring $true
349351

crates/vite_global_cli/src/help.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1182,6 +1182,6 @@ Options:
11821182
documentation_url: Some("https://viteplus.dev/guide/demo"),
11831183
});
11841184

1185-
assert!(output.contains("Documentation: https://viteplus.dev/guide/demo"));
1185+
assert!(strip_ansi(&output).contains("Documentation: https://viteplus.dev/guide/demo"));
11861186
}
11871187
}

0 commit comments

Comments
 (0)