feat: add loading skeleton for Repository Dashboard - #34
Closed
AliMahmoudDev wants to merge 1 commit into
Closed
AliMahmoudDev wants to merge 1 commit into
AliMahmoudDev wants to merge 1 commit into
Conversation
Add a loading.tsx file that mirrors the dashboard page layout: - 4 metric cards with pulsing label and value placeholders - 6 repository cards with name, fullname, badge, and status placeholders - All skeletons use Tailwind animate-pulse matching the existing card styles This follows the Next.js App Router convention where loading.tsx is shown automatically while the server component fetches data. Closes voidswift#3
Member
|
Hey @AliMahmoudDev I'm going to close this specific PR as a duplicate, but your code is already going to be merged into main via Make sure to join our Discord to hang out with the team: https://discord.gg/D2jCpbYgQJ |
Contributor
Author
|
Good PR for the Forge-Lens dashboard! The component looks well-structured. One thought: adding TypeScript interfaces for the props would make the component easier to use and catch type errors at compile time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3
Adds a
loading.tsxfile that displays a skeleton UI while the dashboard server component fetches data.What it does
apps/web/src/app/dashboard/loading.tsxfollowing the Next.js App Router conventionanimate-pulsefrom Tailwind CSS for smooth pulsing animationDesign decisions
loading.tsxconvention instead of a separate component +isLoadingcheck, since the dashboard page is a server component (async function) — React Suspense withloading.tsxis the idiomatic approach