Repository navigation
CI: install Firefox's system libraries only when Firefox needs them - #65
Merged
Merged
Conversation
GitHub's Linux runners ship Firefox, so they already have the libraries it needs; installing them with apt took 24 minutes in a build job and ran the test job into its 20-minute limit when Ubuntu's mirror was slow. The test job now installs them only if Firefox does not start without them, and the build job's smoke test runs first without them and installs them only to try once more after a failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's Linux runners ship Firefox, so they already have the system libraries Playwright's Firefox needs. Installing them with apt (
--with-deps/install-deps) took 24 minutes in a build job on #64 and ran the test job into its 20-minute limit when Ubuntu's mirror was slow. The step normally takes seconds, so most runs are about 5 minutes.install-depsonly if the launch fails.This PR's own run shows whether the fallback was needed: look for "installing the system libraries" in the Linux logs.
🤖 Generated with Claude Code