Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions packages/app/src/components/evaluation/RecipeComparison.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,15 @@ const COLUMNS: DataTableColumn<RecipeRow>[] = [
];

export default function RecipeComparison() {
const { selectedModel, selectedRunDate } = useGlobalFilters();
const { selectedModel } = useGlobalFilters();
const [category, setCategory] = useState<TechniqueCategory | 'all'>('all');

const {
data: benchmarks,
isLoading: bmkLoading,
error: bmkError,
} = useBenchmarks(selectedModel, selectedRunDate || undefined);
// Always use the no-date "latest state across all dates" path. The recipe
// table is meant to surface current recipe variants, not historical data —
// a stale `selectedRunDate` inherited from /inference would hide rows
// ingested on more recent dates (e.g. the user reported missing the
// batch-size filter chip because mnbt rows landed after the sticky date).
const { data: benchmarks, isLoading: bmkLoading, error: bmkError } = useBenchmarks(selectedModel);
const { data: evals, isLoading: evalLoading, error: evalError } = useEvaluations();

const allRows = useMemo(() => {
Expand Down Expand Up @@ -231,14 +232,7 @@ export default function RecipeComparison() {

{!loading && rows.length === 0 && (
<div className="rounded-md border border-border bg-card p-6 text-sm text-muted-foreground">
No data for <strong>{selectedModel || '(no model)'}</strong>
{selectedRunDate ? (
<>
{' '}
on <strong>{selectedRunDate}</strong>
</>
) : null}
. Pick a different model or date.
No data for <strong>{selectedModel || '(no model)'}</strong>. Pick a different model.
</div>
)}

Expand Down
16 changes: 16 additions & 0 deletions packages/app/src/lib/chart-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,16 @@ export const getHardwareKey = (entry: AggDataEntry): string => {
} else if (entry['spec_decoding'] && entry['spec_decoding'] !== 'none') {
normalizedHwName = `${normalizedHwName}_${entry['spec_decoding']}`;
}
// Topology suffix when there's more than one GPU in the deployment, so that
// 1× and 2× (or larger) deployments don't collapse into a single chart
// series. Suppressed for single-GPU runs to keep parity with upstream
// legends. Disagg = prefill + decode pools; non-disagg = single pool.
const totalGpus = entry.disagg
? (entry.num_prefill_gpu ?? 0) + (entry.num_decode_gpu ?? 0)
: (entry.num_prefill_gpu ?? entry.num_decode_gpu ?? 0);
if (totalGpus > 1) {
normalizedHwName = `${normalizedHwName}_${totalGpus}x`;
}
return normalizedHwName;
};

Expand Down Expand Up @@ -224,6 +234,7 @@ export function buildAvailabilityHwKey(
framework?: string,
specMethod?: string,
disagg?: boolean,
totalGpus?: number,
): string {
let hwKey = hardware.split('-')[0];
const fw = framework ? resolveFrameworkAlias(framework) : undefined;
Expand All @@ -241,6 +252,11 @@ export function buildAvailabilityHwKey(
}
if (specMethod === 'mtp') hwKey = `${hwKey}_mtp`;
else if (specMethod && specMethod !== 'none') hwKey = `${hwKey}_${specMethod}`;
// Optional topology suffix — keeps 1× and 2× deployments as separate
// legend entries. Mirror of the suffix in getHardwareKey above. Callers
// that don't know the topology (e.g. legacy availability rows lacking GPU
// counts) pass undefined and the suffix is skipped.
if (totalGpus !== undefined && totalGpus > 1) hwKey = `${hwKey}_${totalGpus}x`;
return hwKey;
}

Expand Down
Loading