Skip to content

Present Push and Pull VCFA and vROPS default tasks - #232

Open
GSYankov wants to merge 4 commits into
masterfrom
feature/vcfa-and-vrops-default-tasks
Open

GSYankov wants to merge 4 commits into
masterfrom
feature/vcfa-and-vrops-default-tasks

Conversation

@GSYankov

Copy link
Copy Markdown

Description

Adds support for VCFA (all-apps) and vROps projects and their Maven profiles, and fixes the local development (F5) setup.

VCFA and vROps project tasks (de36093)

  • Recognize the com.vmware.pscoe.vcf:all-apps-package and com.vmware.pscoe.vrops:vrops-package archetypes (PomFile, ProjectArchetypes).
  • Provide default Push / Pull build tasks for them (vcfa-all-apps:push|pull, vrops:push|pull).
  • Fix PomFile.modules for a base pom.xml with a single <module>: the XML parser returns a string instead of an array in that case.

Non-vRO Maven profiles (732fc83)

  • The profile picker used to list only profiles that define vro.host. It now also lists profiles that define vrang.host, vcd.host, vrops.host or vcfa.host (ConfigurationManager.profileHostKeys), so vROps, VCD and VCFA profiles can be selected and used by the Maven tasks.
  • The picker entry and the status bar show whichever host the profile defines, instead of reading vro.host only.
  • StatusBarController no longer throws Missing 'vro.host' property when a non-vRO profile is selected. The error had stopped the status bar from switching to the new profile. The vRO hint-collection button is shown, and collection is auto-triggered on a profile switch, only for profiles with vro.host.
  • Added the new host keys to the MavenProfile type.

Development setup (3ffe6c2)

  • .vscode/tasks.json: the gulp: watch preLaunchTask was declared as "type": "gulp". That type only resolves when VS Code's gulp.autoDetect is on, and it is off by default, so F5 failed with Could not find the task 'gulp: watch'. The tasks are now shell tasks that run the local gulp through npx.
  • package.json: restored "main": "./extension/out/extension". Commit 7f76ca5 had accidentally committed the dist entry point that gulp package writes only temporarily, so the Extension Development Host could not find the extension. gulp package still switches to dist while it builds the .vsix.

Known limitations with a non-vRO profile active (follow-up)

  • The vRO Explorer view still builds its tree, and expanding a node fails with Missing 'vro.host' property.
  • On activation, vRO hint collection is still triggered (extension.ts). It fails quietly and falls back to local hints, which only adds log noise.
  • vRO commands (Show Actions/Workflows, Run Action, etc.) fail with the raw Missing 'vro.host' error.
  • VroRestClient authenticates once, when it is constructed, so credentials are not refreshed after a profile switch. This bug existed before this PR.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (single-module pom.xml test; there are no tests for the profile filter)
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

  • gulp compile and gulp test pass. The new unit test covers parsing a pom.xml with a single <module>.
  • Launched the Extension debug configuration (F5) in a WSL Remote setup. The gulp: watch preLaunchTask resolves and the extension activates from extension/out.
  • With a ~/.m2/settings.xml containing vRO and vROps profiles, the vROps profiles now appear in Change Profile, can be selected, and the status bar shows the selected profile with its host.

Release Notes

  • Push/Pull build tasks for VCFA and vROps projects, and the profile picker now lists Maven profiles for vRA 8, VCD, vROps and VCFA as well as vRO.

@GSYankov
GSYankov requested a review from a team as a code owner October 27, 2026 15:48
Copilot AI balanced review requested due to automatic review settings October 27, 2026 15:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants