Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for VCFA (all-apps) and vROps projects and their Maven profiles, and fixes the local development (F5) setup.
VCFA and vROps project tasks (
de36093)com.vmware.pscoe.vcf:all-apps-packageandcom.vmware.pscoe.vrops:vrops-packagearchetypes (PomFile,ProjectArchetypes).vcfa-all-apps:push|pull,vrops:push|pull).PomFile.modulesfor a basepom.xmlwith a single<module>: the XML parser returns a string instead of an array in that case.Non-vRO Maven profiles (
732fc83)vro.host. It now also lists profiles that definevrang.host,vcd.host,vrops.hostorvcfa.host(ConfigurationManager.profileHostKeys), so vROps, VCD and VCFA profiles can be selected and used by the Maven tasks.vro.hostonly.StatusBarControllerno longer throwsMissing 'vro.host' propertywhen a non-vRO profile is selected. The error had stopped the status bar from switching to the new profile. The vRO hint-collection button is shown, and collection is auto-triggered on a profile switch, only for profiles withvro.host.MavenProfiletype.Development setup (
3ffe6c2).vscode/tasks.json: thegulp: watchpreLaunchTask was declared as"type": "gulp". That type only resolves when VS Code'sgulp.autoDetectis on, and it is off by default, so F5 failed with Could not find the task 'gulp: watch'. The tasks are now shell tasks that run the local gulp throughnpx.package.json: restored"main": "./extension/out/extension". Commit7f76ca5had accidentally committed thedistentry point thatgulp packagewrites only temporarily, so the Extension Development Host could not find the extension.gulp packagestill switches todistwhile it builds the.vsix.Known limitations with a non-vRO profile active (follow-up)
Missing 'vro.host' property.extension.ts). It fails quietly and falls back to local hints, which only adds log noise.Missing 'vro.host'error.VroRestClientauthenticates once, when it is constructed, so credentials are not refreshed after a profile switch. This bug existed before this PR.Checklist
pom.xmltest; there are no tests for the profile filter)Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
gulp compileandgulp testpass. The new unit test covers parsing apom.xmlwith a single<module>.Extensiondebug configuration (F5) in a WSL Remote setup. Thegulp: watchpreLaunchTask resolves and the extension activates fromextension/out.~/.m2/settings.xmlcontaining vRO and vROps profiles, the vROps profiles now appear in Change Profile, can be selected, and the status bar shows the selected profile with its host.Release Notes