[Bug]: Can't deploy towards vCenter server with vDS port group

[NLBasn]

Holorouter Version

9.1

VCF Version

VCF 9.1

Target Type

vCenter Cluster

Describe the bug

When trying to deploy v9.1 using a vDS, the documentation screenshot states the Promiscuous mode as Reject and MAC learning enabled.
This is the correct setup. However the Precheck checks the Promiscuous mode instead of the maclearning status.

Reproduction steps

1. Do a new deployment towards a vCenter server with vDS

Expected behavior

To install correctly.

Relevant logs

Additional context

Workaround:
Set-vdSecurityPolicy -AllowPromiscuous:$false before starting deployment.
change to Set-vdSecurityPolicy -AllowPromiscuous:$true after check is complete

Fix:

Precheck.psm1:

1536   $port_group_security_settings = $port_group.ExtensionData.Config.DefaultPortConfig.SecurityPolicy
+1537  $port_group_maclearning_settings = $port_group.ExtensionData.Config.DefaultPortConfig.MacManagementPolicy.MacLearningPolicy

-1539 if($port_group_security_settings.AllowPromiscuous.Value -eq $false){
-1540 Write-Log -Message "Selected trunk port group $($selectedPortGroup.Name) has promiscuous mode security policy set to Reject. This needs to be set to Accept before deploying HoloDeck" -Level "ERROR"

+1539 if ($port_group_maclearning_settings.Enabled -eq $false){
+1540 Write-Log -Message "Selected trunk port group $($selectedPortGroup.Name) has macLearning status set to Disabled. This needs to be set to Enabled before deploying HoloDeck" -Level "ERROR"


1665   $port_group_security_settings = $port_group.ExtensionData.Config.DefaultPortConfig.SecurityPolicy
+1666  $port_group_maclearning_settings = $port_group.ExtensionData.Config.DefaultPortConfig.MacManagementPolicy.MacLearningPolicy

-1667 if($port_group_security_settings.AllowPromiscuous.Value -eq $false){
-1668 Write-Log -Message "Selected trunk port group $($selectedPortGroup.Name) has promiscuous mode security policy set to Reject. This needs to be set to Accept before deploying HoloDeck" -Level "ERROR"

+1667 if ($port_group_maclearning_settings.Enabled -eq $false){
+1668 Write-Log -Message "Selected trunk port group $($selectedPortGroup.Name) has macLearning status set to Disabled. This needs to be set to Enabled before deploying HoloDeck" -Level "ERROR"

[dhruv-tyagi-broadcom]

Thanks for pointing this out. At the time we released Holodeck 9.1, we were suggesting to keep prom. mode to accept, hence that was present in the code. As we saw people face issues due to it, we reverted back to keeping it to reject. The code will be updated in the next release.