Repository navigation
fix(provider-utils): read offset-less event times in their own time zone - #37
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
eventTimeToInstant parsed a dateTime without an offset with Date.parse, so it used the host's zone and ignored timeZone. The mock calendar then reported busy times hours off wherever the host zone differed from the event's.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eventTimeToInstantparsed a timeddateTimewithDate.parse. When the value has no offset, such as{ dateTime: '2026-11-09T10:00:00', timeZone: 'Europe/Berlin' }(the form the README and docs use), that reads it in the host machine's zone and ignorestimeZone. The mock calendar uses this for busy times, listing windows and recurrence expansion, so on a machine in IST a 10:00 Berlin meeting was reported busy at 04:30Z instead of 09:00Z, andfindFreeTimeoffered slots on top of it. Real providers aren't affected: they send the wall-clock time and zone to the API.Offset-less values are now parsed as wall-clock time in their own
timeZonewith the existinglocalToInstant. Values with an offset orZstill go throughDate.parse.Verified
TZ=Asia/Kolkata(expected 09:00Z, got 04:30Z) and passes with the fix.TZ=Asia/Kolkata:getFreeBusynow returns 09:00Z to 11:00Z for a 10:00 to 12:00 Berlin event.TZ=UTCandTZ=America/Los_Angeles; lint and typecheck clean.