Repository navigation
fix: make the reference verifier pass its own suite (16/16) + runner field-presence - #1
Merged
Merged
Conversation
… field presence A01-A04 verified with NO pin, so the fail-closed verifier returned authority_ok=null -> ok=false and the suite reported NON-CONFORMANT (12/16) on a clean install. The accept builders now pin the honest fixture key PUB (mirroring R12's reject-on-mismatch), so authority is established and ok=true -- without weakening the verifier default. Vectors regenerated (keys/nonces rotated). Also: the runner compared checks.get(k) is v, treating an ABSENT flag as an expected null; now requires k in checks, so a missing check can't silently pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a clean install,
python -m conformancereported NON-CONFORMANT (12/16): the four honest-accept cases (A01-A04) were verified with no pin, so the (correct) fail-closed verifier returnedauthority_ok=null->ok=false. A verification product whose own reference implementation fails its own suite is a credibility problem.Fix
PUBinverify_kwargs— the same key R12 pins to reject an attacker re-sign. Authority is established ->ok=true, without changing the verifier's fail-closed default. (A public-key pin is not a secret or a network call, so offline verification is preserved.)checks.get(k) is vtreated an absent flag as an expectednull; now requiresk in checks, so a missing check can't silently pass.Result
Note: this makes the suite honest and green; it does not change what a receipt proves (the dishonest-issuer limitation still requires attested capture).