Skip to content

fix: make the reference verifier pass its own suite (16/16) + runner field-presence - #1

Merged
logickeau merged 1 commit into
mainfrom
fix/conformant-accept-vectors
Oct 16, 2026
Merged

logickeau merged 1 commit into
mainfrom
fix/conformant-accept-vectors

Conversation

@logickeau

Copy link
Copy Markdown
Contributor

Problem

On a clean install, python -m conformance reported NON-CONFORMANT (12/16): the four honest-accept cases (A01-A04) were verified with no pin, so the (correct) fail-closed verifier returned authority_ok=null -> ok=false. A verification product whose own reference implementation fails its own suite is a credibility problem.

Fix

  • Accept builders now pin the honest fixture key PUB in verify_kwargs — the same key R12 pins to reject an attacker re-sign. Authority is established -> ok=true, without changing the verifier's fail-closed default. (A public-key pin is not a secret or a network call, so offline verification is preserved.)
  • Vectors regenerated (keys/nonces/timestamps rotated; verdicts unchanged).
  • Runner: checks.get(k) is v treated an absent flag as an expected null; now requires k in checks, so a missing check can't silently pass.

Result

-> 16/16 receipt cases as specified
CONFORMANT

Note: this makes the suite honest and green; it does not change what a receipt proves (the dishonest-issuer limitation still requires attested capture).

… field presence

A01-A04 verified with NO pin, so the fail-closed verifier returned authority_ok=null -> ok=false and the suite reported NON-CONFORMANT (12/16) on a clean install. The accept builders now pin the honest fixture key PUB (mirroring R12's reject-on-mismatch), so authority is established and ok=true -- without weakening the verifier default. Vectors regenerated (keys/nonces rotated). Also: the runner compared checks.get(k) is v, treating an ABSENT flag as an expected null; now requires k in checks, so a missing check can't silently pass.
@logickeau
logickeau merged commit 06d5334 into main Oct 16, 2026
5 checks passed
@logickeau
logickeau deleted the fix/conformant-accept-vectors branch October 16, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant