Skip to content

🐛 Fix Windows COM apartment handling for file dialogs#616

Merged
vinceglb merged 2 commits into
mainfrom
vinceglb/fix-issue-600-windows-com-apartment
Jul 21, 2026
Merged

🐛 Fix Windows COM apartment handling for file dialogs#616
vinceglb merged 2 commits into
mainfrom
vinceglb/fix-issue-600-windows-com-apartment

Conversation

@vinceglb

@vinceglb vinceglb commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Run Windows file dialogs on a dedicated STA thread.
  • Balance COM initialization and cleanup across success and failure paths.
  • Add unit and Windows integration coverage for threading, HRESULT failures, serialization, and cleanup.
  • Ignore local .scratch/ files.

#600

Testing

  • Added JVM unit tests for the dialog executor.
  • Added a Windows integration test covering COM dialog creation from an MTA caller.
  • Full test suite not run (not requested).

@vinceglb
vinceglb merged commit 1c9ae18 into main Jul 21, 2026
31 of 35 checks passed
@vinceglb
vinceglb deleted the vinceglb/fix-issue-600-windows-com-apartment branch July 21, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant