Repository navigation
Remove old-version pickle test after compatibility cleanup - #321
Merged
Merged
Conversation
antonsoo
force-pushed
the
fix/current-pickle-test-scope
branch
from
October 18, 2026 09:11
16e1480 to
b6dce05
Compare
Owner
|
Thanks, i was too quick to commit. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #318 and the decision to leave older-version pickles unsupported.
6073390removes the historical attribute-order repair, buttest_restore_old_center_of_gravity_attribute_orderstill requires it and fails for both body types. Remove that test to match the accepted scope. The current-format off-center copy/pickle test remains, and production code is unchanged.Validation: the full project runner
python -m pymunk.testssucceeds (297 tests run, two existing skips), Black passes for the test file, and all 48 native current-format checkpoint scenes retain their complete simulation histories.