Repository navigation
Preserve custom spring force and torque callbacks when copying - #317
Merged
Merged
Conversation
Owner
|
Thanks for finding and fixing the bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom spring laws currently disappear during copying or pickling, so a restored simulation silently uses the default force or torque function:
Add
force_funcandtorque_functo their classes' general-state lists. Restoration then uses the existing setters to install the callback or the native default function. Pickle requires a pickleable callback, as with other serialized callbacks; it no longer silently discards a custom law.Validation:
python -m pymunk.testsrun passes (289 tests, two skipped).5.6e-17for these undamped setups.Validation used Linux and Python 3.12. Existing unrelated mypy and whole-file formatting failures are unchanged; the edited test module passes Black.