Repository navigation
Mejora visual y navegación de la landing - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
¿Qué hace este PR?
Mejora la landing de Sacré con navegación SPA estable, shell persistente y mayor contraste visual en modo claro y fondos.
¿Por qué?
La navegación interna generaba sensación de recarga porque el header se remontaba entre rutas y algunos links salteaban React Router. Además, varios elementos dorados y el tapiz de fondo tenían bajo contraste en modo claro.
Cambios incluidos
RootPagepersistente con header, footer yOutlet.Linkde React Router y maneja hashes de la página actual.Cómo probarlo
pnpm lint.pnpm typecheck.pnpm test --run.Checklist
pnpm lintpasa sin errorespnpm typecheckpasa sin errorespnpm test --runpasa sin erroresconsole.logde debug