Fix COPR build failure induced by git tag finder - #39
Merged
Merged
Conversation
…cipe #38 Moved version resolution with `git describe` from Makefile parsing into the recipe, ensuring `git` is installed beforehand. Added error handling for clones without reachable tags. Updated `.copr/Makefile` and `CHANGELOG.md` accordingly. Signed-off-by: Vedran Hrabar <vedran.hrabar@outlook.com>
vhrabar
added a commit
that referenced
this pull request
Aug 19, 2026
Fix COPR build failure induced by git tag finder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a build failure in the COPR packaging process by deferring the resolution of the release version until after
gitis installed, ensuring the version is correctly determined and providing a clear error message if no tag is found. This improves the robustness of the build process and provides better feedback in error cases.Build process improvements:
git describefrom Makefile parsing time to execution time in thesrpmrecipe, ensuringgitis installed before version resolution and preventing empty version errors. Now, if no tag is found, the build fails with a clear message instructing the user to submit the build with a tagged commit. (.copr/Makefile)srpmrecipe to use the resolved version variable instead of the previousVERSIONmake variable. (.copr/Makefile)Documentation: