Skip to content

feat: requests metric for rate limiting sercher #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrageHK wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: requests metric for rate limiting sercher #4850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions en/performance/rate-limiting-searcher.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ <h3 id="per-client-quotas">Per Client Quotas</h3>

<h2 id="metrics">Metrics</h2>
<p>
The searcher will emit the <a href="../operations/metrics.html">count metric</a>
<code>requestsOverQuota</code> with the dimension <code>[rate.idDimension=rate.id]</code>.
The searcher will emit the <a href="../operations/metrics.html">count metrics</a>
<code>requests</code> and <code>requestsOverQuota</code>, both with the dimension
<code>[rate.idDimension=rate.id]</code>. <code>requests</code> counts all requests checked
by this searcher, while <code>requestsOverQuota</code> counts the subset of those that
were rejected (or would have been rejected, in <code>rate.dryRun</code> mode).
</p>
5 changes: 5 additions & 0 deletions en/reference/container-metrics-reference.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,11 @@
<td>operation</td>
<td>Number of queries matching no documents</td>
</tr>
<tr>
<td><p id="requests">requests</p></td>
<td>operation</td>
<td>The number of requests processed by the rate limiter</td>
</tr>
<tr>
<td><p id="requestsOverQuota">requestsOverQuota</p></td>
<td>operation</td>
Expand Down
5 changes: 5 additions & 0 deletions en/reference/operations/metrics/container.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,11 @@
<td>operation</td>
<td>Number of queries matching no documents</td>
</tr>
<tr>
<td><p id="requests">requests</p></td>
<td>operation</td>
<td>The number of requests processed by the rate limiter</td>
</tr>
<tr>
<td><p id="requestsOverQuota">requestsOverQuota</p></td>
<td>operation</td>
Expand Down
6 changes: 6 additions & 0 deletions en/reference/operations/metrics/vespa-metric-set.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,12 @@ <h2 id="container-metrics">Container Metrics</h2>
<td>rate</td>
<td>Number of queries matching no documents</td>
</tr>
<tr>
<td><p id="requests">requests</p></td>
<td>operation</td>
<td>count, rate</td>
<td>The number of requests processed by the rate limiter</td>
</tr>
<tr>
<td><p id="requestsOverQuota">requestsOverQuota</p></td>
<td>operation</td>
Expand Down
6 changes: 6 additions & 0 deletions en/reference/vespa-set-metrics-reference.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,12 @@ <h2 id="container-metrics">Container Metrics</h2>
<td>rate</td>
<td>Number of queries matching no documents</td>
</tr>
<tr>
<td><p id="requests">requests</p></td>
<td>operation</td>
<td>count, rate</td>
<td>The number of requests processed by the rate limiter</td>
</tr>
<tr>
<td><p id="requestsOverQuota">requestsOverQuota</p></td>
<td>operation</td>
Expand Down