Repository navigation
Conversation
| if (enabled === true) { | ||
| // MID is mandatory when BUNDLE is used and cannot be disabled by this API. | ||
| // Some browsers may report it as stopped after negotiation, but reject the | ||
| // entire list if that direction is submitted again. |
There was a problem hiding this comment.
This is an IA written PR. Which is the real evidence behind this IA predictable comment? It clearly looks like if you prompted to the IA agent some statement (what is said in the reported issue ticket) and it just generated a solution assuming that issue is true or normal behavior in some browsers. Is this a bug already reported in libwebrtc?
|
Thanks for asking for concrete evidence. There is already a related libwebrtc tracking bug: webrtc:439514253, which is referenced by the upstream changes for remembering RTP header-extension negotiation state and the The evidence for this specific failure is in issue #394: it includes a standalone This PR addresses the client-side trigger: when applying a forced extension setting, it normalizes the mandatory MID entry before submitting the full list, so the browser-reported stopped value is not sent back. I have not independently run the standalone browser reproduction; the reproduction and its field-trial result are reported in issue #394. |
|
Sorry, I cannot talk to IA agents. I asked you (the human), not your IA agent. I'm closing this PR. Will fix the issue on my own. |
Summary
stoppedafter negotiation.Evidence
Issue #394 documents that
getHeaderExtensionsToNegotiate()can return MID asstopped, whilesetHeaderExtensionsToNegotiate()rejects the submitted list unless MID issendrecv. The helper currently resubmits the full list when enabling another extension, causing that request to fail.The regression test starts with MID
stoppedand abs-capture-timerecvonly, then verifies that the helper submits MID assendrecvand enables abs-capture-time.Checks
Merge Danger
Low. This only normalizes the mandatory MID extension direction while applying the existing forced-extension settings; other extension directions retain their current behavior.