onRoomReady/onChatStarted callback support#38
Open
subhadipverloop wants to merge 3 commits into
Open
Conversation
Handling onChatStarted/onRoomReady Functionlity of livechat v2 android methods - setChatStartedListener setRoomReadyListner
raghav39
requested changes
May 12, 2026
| var verloop: Verloop? = null | ||
| var verloop2: Verloop? = null | ||
|
|
||
| private val chatStarted: () -> Unit = { |
Collaborator
There was a problem hiding this comment.
we should pass room Id as a param to this. Same for roomReady
Collaborator
Author
There was a problem hiding this comment.
Okay, I thought of adding this, skipped this cause roomID is internal. will add this
type on setRoomReadyListener updated readme.md
raghav39
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling onChatStarted/onRoomReady Functionlity of livechat v2
android methods -
setChatStartedListener
setRoomReadyListner