fix(format-url): preserve all colons in auth and encode all # in search - #98472
Open
suletetes wants to merge 4 commits into
Open
fix(format-url): preserve all colons in auth and encode all # in search#98472suletetes wants to merge 4 commits into
suletetes wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two one-line correctness fixes to
formatUrl(Next's port of Node's legacyurl.format), each caused by a non-globalreplacethat only handled the first occurrence.encodeURIComponent(auth).replace(/%3A/i, ':')→/%3A/gi. The non-global flag re-decoded only the first%3A, souser:pa:sscame out asuser:pa%3Ass@…. Node decodes every colon in userinfo.search.replace('#', '%23')→search.replace(/#/g, '%23'). Only the first#was encoded, so?a=1#b#cyielded?a=1%23b#cinstead of?a=1%23b%23c.Why
Both diverged from Node's
url.format. Verified byte-for-byte parity against Node for multi-colon (user:pa:ss,a:b:c:d), single-colon,@-in-auth, query object, multi-#search, and bare-hash inputs. Thegflag only affects strings with more than one match, so single-occurrence inputs (the common case) are unchanged.Tests
New
test/unit/format-url.test.ts(7 cases), all exacttoBeassertions verified against Node:@-encoding, query object, hash normalization#search encoding regression guardnpx jest test/unit/format-url.test.ts→ 7 passed.