fix: resolve docs from hoisted Next.js installations - #155
Open
gaojude wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a workspace hoists
nextaboveproject_path, the docs gateway only checks the child'snode_modules. It reports the declared version and points to missing docs despite an installed package being available through normal module resolution.Resolve
next/package.jsonfrom the requested project withcreateRequire, derive both the installed version and docs location from that package, and return an absolutedocsPath. Update search instructions and the README, and add a patch changeset.Validation:
pnpm build,pnpm typecheck, and the completepnpm exec vitest run: 35 tests passed.^16.0.0range. VerifiedversionSource: installed, the exact version, and an absolute docs directory that exists.Local validation used macOS arm64, Node.js 24.19.0, and pnpm 9.15.9. The uploaded GitHub-signed commit has the same Git tree as the tested checkout.
Windows CI caught doubled backslashes in the shell-style search hint. The hint now points directly to the readable filesystem path; the complete 35-test local suite passed again after this correction.