fix: preserve downstream MCP tool error status - #153
Merged
Conversation
devjiwonchoi
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A downstream Next.js tool result with
isError: trueis currently wrapped insuccess: true, and the outer MCP result has no error flag. Clients can treat a failed runtime operation as successful.Let
nextjs_callreturn an MCPCallToolResultand preserve explicit downstream tool errors on the outer response. Request failures also setisError; healthy calls retain the existing JSON payload. The registration handler passes structured results through and continues wrapping string-returning tools. Adds a patch changeset.Validation:
pnpm build,pnpm typecheck, and the completepnpm exec vitest run: 36 tests passed.compile_routefailure directly with the stdio proxy: both reportisError: true, and the proxy reportssuccess: false.This preserves explicit MCP error semantics; it does not infer failure by parsing arbitrary text content returned by downstream tools.
Local validation used macOS arm64, Node.js 24.19.0, and pnpm 9.15.9. The uploaded GitHub-signed commit has the same Git tree as the tested checkout.