fix(skills): preserve TypeTable values in generated references - #493
Open
changbaebang wants to merge 2 commits into
Open
changbaebang wants to merge 2 commits into
changbaebang wants to merge 2 commits into
Conversation
Contributor
|
@changbaebang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous regex stopped at the first quote or closing brace. This produced values such as
unknown,React.ComponentProps<, andRiveParameters[in the generated skill even though the source MDX contained complete types.Verification
pnpm test --filter=@repo/scriptspnpm exec tsc --noEmit -p packages/scripts/tsconfig.jsonpnpm exec oxlint packages/scripts/src/generate-skills.ts packages/scripts/src/type-table.ts packages/scripts/src/type-table.test.tspnpm exec oxfmt --check packages/scripts/src/generate-skills.ts packages/scripts/src/type-table.ts packages/scripts/src/type-table.test.ts packages/scripts/package.jsonpnpm generate-skillsand verified the generated tree is unchangedFollow-up note
The generation workflow currently watches
apps/docs/content/docs/**/*.mdx, while component references are sourced fromapps/docs/content/components/**/*.mdx. That explains why the recently added Question component did not trigger regeneration; #494 tracks the watched-path correction separately.