Skip to content

fix(skills): preserve TypeTable values in generated references - #493

Open
changbaebang wants to merge 2 commits into
vercel:mainfrom
changbaebang:fix/skill-type-table-generation
Open

changbaebang wants to merge 2 commits into
vercel:mainfrom
changbaebang:fix/skill-type-table-generation

Conversation

@changbaebang

@changbaebang changbaebang commented Sep 19, 2026

Copy link
Copy Markdown

Summary

  • parse TypeTable prop metadata with the TypeScript AST instead of nested-object regexes
  • preserve quoted unions, indexed access types, generic types, object defaults, and descriptions containing quotes
  • escape Markdown table separators and add focused regression tests
  • regenerate AI Elements skill references, including the missing Question reference and examples

The previous regex stopped at the first quote or closing brace. This produced values such as unknown, React.ComponentProps<, and RiveParameters[ in the generated skill even though the source MDX contained complete types.

Verification

  • pnpm test --filter=@repo/scripts
  • pnpm exec tsc --noEmit -p packages/scripts/tsconfig.json
  • pnpm exec oxlint packages/scripts/src/generate-skills.ts packages/scripts/src/type-table.ts packages/scripts/src/type-table.test.ts
  • pnpm exec oxfmt --check packages/scripts/src/generate-skills.ts packages/scripts/src/type-table.ts packages/scripts/src/type-table.test.ts packages/scripts/package.json
  • reran pnpm generate-skills and verified the generated tree is unchanged

Follow-up note

The generation workflow currently watches apps/docs/content/docs/**/*.mdx, while component references are sourced from apps/docs/content/components/**/*.mdx. That explains why the recently added Question component did not trigger regeneration; #494 tracks the watched-path correction separately.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@changbaebang is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant